Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Do not bind the touch handlers if we are not showing ripple effects #8463

Merged
merged 2 commits into from Sep 29, 2017
Merged

[Switch] Do not bind the touch handlers if we are not showing ripple effects #8463

merged 2 commits into from Sep 29, 2017

Conversation

NLincoln
Copy link
Contributor

Fixes #8443

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: switch This is the name of the generic UI component, not the React module! v0.x labels Sep 29, 2017
@oliviertassinari oliviertassinari merged commit 1abd438 into mui:master Sep 29, 2017
@oliviertassinari
Copy link
Member

@NLincoln Thanks!

@NLincoln NLincoln deleted the bugfix/8443 branch September 29, 2017 21:15
@oliviertassinari oliviertassinari changed the title Do not bind the touch handlers if we are not showing ripple effects [Switch] Do not bind the touch handlers if we are not showing ripple effects Sep 30, 2017
djbuckley added a commit to manchesergit/material-ui that referenced this pull request Oct 10, 2017
@djbuckley
Merge remote-tracking branch 'call_em_all_-_master/master'
9bf54b8 
* call_em_all_-_master/master:
  [Stepper] Allow invalid children (mui#8634)
  [Docs] Add v0.19.4 to versions.json
  [CHANGELOG] Prepare v0.19.4
  v0.19.4
  [CHANGELOG] Prepare v0.19.4
  [docs] Small fixes (mui#8594)
  [core] Upgrade dependencies (mui#8578)
  Apply valueLink only if defined via props (mui#8530)
  [Docs] Add v0.19.3 to versions.json
  v0.19.3
  [CHANGELOG] Prepare v0.19.3
  Do not bind the touch handlers if we are not showing ripple effects (mui#8463)
  Move tooltip opacity default into mui theme (mui#8444)

# Conflicts:
#	package.json
#	src/TextField/EnhancedTextarea.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: switch This is the name of the generic UI component, not the React module! v0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NLincoln @oliviertassinari