[flow] Collapse theme is not an external prop

[rosskevin]

No description provided.

[oliviertassinari]

I don't follow. This is not a default property.

[rosskevin]

It's injected by a HOC, not required for a component user to pass in.

[oliviertassinari]

But the property is required for the component to work. I think that being required by the users is another topic, no?

[rosskevin]

This is the exact pattern for flow use in the entire codebase. DefaultProps & Props == internal props.

export Props represents user props only
DefaultProps contains HOC injected and defaultProps internal to the component.

[rosskevin]

This is also why you see classes located in DefaultProps for example

[oliviertassinari]

This is the exact pattern for flow use in the entire codebase.

@rosskevin Oh, I have missed this. I'm gonna change the whole code base. At some point, we might be supporting a naked UI version of the components, without the HOCs. If we remove the HOCs from the equation, I can't think of any reason why it shouldn't be required.

[rosskevin]

FYI - Technically, now that HOCs are correct, instead of adding classes and theme here, we could be importing types from the HOCs and intersecting them here.

[rosskevin]

Also, before you change the pattern for naked, let me know and let's try one. In our apps, I import Props from here to build bigger components. Internally that prop is required, but externally with HOC the result should be the same.

[oliviertassinari]

I have been opening #8477.

[rosskevin]

So I'm going to merge this as-is, because the entire codebase is this way and it is not worth leaving open. We'll pick up the changes in your other PR.

[oliviertassinari]

Nooo, look at the yarn docs:api output...

[oliviertassinari]

+| <span style="color: #31a148">theme *</span> | Object |  |  |