Customize UI components: TextField. #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misha-panyushkin
force-pushed
the
textfield-customization
branch
from
1129ad5
to
df1e2cd
Compare
|
@misha-panyushkin Yes, I think your PR is good - just have a small code cleanup suggestion. 👍 |
misha-panyushkin
force-pushed
the
textfield-customization
branch
from
df1e2cd
to
5332a01
Compare
|
@hai-cea done. |
misha-panyushkin
force-pushed
the
textfield-customization
branch
from
5332a01
to
4a6816e
Compare
|
Also made two steps:
|
misha-panyushkin
force-pushed
the
textfield-customization
branch
from
4a6816e
to
85c2ec9
Compare
|
- add text field component theme; - bind text field component with its theme; - introduce hint and label colors in text field theme (need author permit); - customize textfield hint or float label with custom line height; - caching method call result; - corrected error mode state via setErrorText method call; - introduced textarea setValue method for correct height calculation; - updated disabled text field mode underline to more flexible one; - syntax error fix.
misha-panyushkin
force-pushed
the
textfield-customization
branch
from
85c2ec9
to
a5f40a2
Compare
|
@hai-cea syntax error fixed. |
- renaming method.
hai-cea
added a commit
that referenced
this pull request
Jun 18, 2015
Customize UI components: TextField.
|
Thanks @misha-panyushkin ! |
This was referenced Jun 19, 2015
zannager
added
the
component: text field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update targeted on UI components customization with developers styles pointed out in component theme. As the main part of the PR was introduced TextField component theme and bound it with TextField component itself.
Also there were added hint and label color themes (@hai-cea need your permit for the changes of this kind).
Also added customization of the textfield hint and float label lineHeight style property according to custom height.