New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid] Add alignItems & alignContent properties #8647
Conversation
@sakulstra It needs multiple lines to make a difference. I don't think that we should add it for a simple reason, more options are more overhead for our users and decrease the demo quality. Sure we could have changed it so the Regarding visual regression tests, I think that it's optional, we can be lazy on this feature and wait regression/bugs to add some. Looks good otherwise, good job 👍 |
@oliviertassinari i never worked with a tool like argos, so i want to fix it as a learning experience. The change on InteractiveGrid is intended(alignItems instead of align), but why is PositionedTooltips broken on argos? locally it seems to be the same like before the change. |
🙊 i didn't realize there was an actual test file for that :/ only looked at the docs 👍 |
I have forgotten my laptop at the office. I can't merge anything before tomorrow. |
@sakulstra Thanks :) |
* breaking(grid-align): rename align to alignItems * feat(grid): added alignContent prop * fix docs * fix(docs): new naming * fix tooltip docs :/ * remove alignContent from interactive demo and add it to api docs * fix regression test
@oliviertassinari not sure if it makes sense to add alignContent to the interactive demo - at least not in the current format, as alignContent won't make any difference.
Breaking change
Closes #8599