[Popover] Add a marginThreshold property #8815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Popover/Popover.js
Outdated
| @@ -115,6 +116,10 @@ export type Props = { | |||
| */ | |||
| getContentAnchorEl?: Function, | |||
| /** | |||
| * Specifies how close to the edge of the window the popover can appear | |||
|
I'm about to make a release. Sorry, this PR will be in the next train 🚋 . |
oliviertassinari
changed the title
oliviertassinari
changed the title
|
@eyn Thank you! |
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
[Popover] Add a marginThreshold property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to choose how large the marginThreshold is and have popovers closer than 16px from the edge of the screen if they so wish.
Should we set default to 2 theme units rather than 16?