[Input] Made the labels for adorned elements not shrink on end adornment #8882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per mui#8881 this provides more consistency. This was not done with the startAdornment for two reasons: 1) I don't yet know how, and I don't think it's possible to do generically due to indeterminate adornment width. Could be wrong due to ignorance. 2) "$ Amount" just doesn't feel right. Thus I'm open to suggestions.
|
And the Argos difference is expected :) |
oliviertassinari
changed the title
oliviertassinari
added
component: text field
|
@kf6kjg Thank you :) |
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
…ent (mui#8882) * Made the labels for adorned elements not shrink on end adornment As per mui#8881 this provides more consistency. This was not done with the startAdornment for two reasons: 1) I don't yet know how, and I don't think it's possible to do generically due to indeterminate adornment width. Could be wrong due to ignorance. 2) "$ Amount" just doesn't feel right. Thus I'm open to suggestions. * remove some dead code
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides more consistency.
This was not done with the startAdornment for two reasons:
Thus I'm open to suggestions.
Closes #8881