[BottomNavigation] Allow null bottom navigation items #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -64,6 +64,7 @@ function BottomNavigation(props: ProvidedProps & Props) { | |||
| const className = classNames(classes.root, classNameProp); | |||
|
|
|||
| const children = React.Children.map(childrenProp, (child, childIndex) => { | |||
| if (child === null) return null; | |||
There was a problem hiding this comment.
What about using React.Children.isValidElement instead?
There was a problem hiding this comment.
You meant if (!React.isValidElement(child)) return null; ?
Yes, that would be even better
oliviertassinari
approved these changes
Nov 6, 2017
oliviertassinari
changed the title
oliviertassinari
added
component: bottom navigation
|
@ciroja Thank you! |
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
* Allow null bottom navigation items * Update BottomNavigation.spec.js * Prettifying * Prettifying * removig spaces * removing spaces * using isValidElement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with rendering null children for BottomNavigation.
For v.0.19x it is fixed by #8925
But it seems that in v1-beta (v1.0.0-beta20) this issue still exists anyway.
This PR solves this issue.