New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix misc typos, grammar and add minor clarifications #9112
Conversation
I don't know. If you think it should why not :).
I'm hoping we can add more information on this section.
Why not.
It's some variables that are specific to the UI you are implementing. For instance, the color of a failing build on Argos-CI.
It's demonstrating how to use our styling solution. |
Just that it doesn't really seem to have anything to do with customization, so it's either Getting Started, or Guides. While it's good background to have, it doesn't feel like necessary info to have to get started, ergo Guides. 😄
Okay, cool. But... I tried updating the title, renaming the md file, and changing the route (and restarting) but I'm getting a 404. Is there a trick to it? 😕
So, "Custom styles"? I guess modifications to the default theme is also customization, but these are styles that are not part of the default theme, right? (Or is this a "Brand" thing?) I just didn't grok the "business" part.
Don't we have that already here? Looking again, it seems like it's basically the same code, other than adding a couple of unused props. I was originally confused because it doesn't come with any introduction or explanation. Now I'm even more convinced it's redundant. Thoughts? |
Sounds good.
next.js use the filename in
Sounds good.
Oh, sorry. It's not the same demo. The first one is using |
I'm sure that's what I did, but I'll try again.
So it's showing the interoperability of native jss Is the paragraph above that demo about Material-UI using a fork still valid? It seems we're using the jss npm package. |
@oliviertassinari I tried moving api.md from customization to guides, and updated withRoot.js to add:
to /guides children array (and removing the equivalent from /customization), but even after restarting, I get a 404 (the same problem I had with renaming examples.md to example-projects.md). Is there another step that I"m missing? |
Let me have a look.
This is a new section (less than a month old). Yes, it's still valid. We haven't forked jss, only react-jss. |
Sorry, I meant, react-jss. The reason I asked is that in |
@mbrookes Only some modules have been forked, not all the package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna merge this PR as I want to ship a new beta release by this evening.
Not yet, I've another batch to include. |
Ohhh 😬 |
Okay, I'll do another PR. |
Ok, I'm gonna hold on the release, it's time to upgrade the dependencies. |
* [docs] Fix misc typos, grammar and add minor clarifications. * rename
@oliviertassinari It's been a while, so I have given the (non-demo / non-API) docs a cover-to-cover read, and made a few tweaks. The only real addition is in
overrides.md,
so please take a look and make sure it's technically correct.We seem to have a bit of a mix of hard-wrapped, not wrapped at all, and variable-line-length. Other than in overrides, I resisted changing that, as it would make the other changes hard to follow, but I'm happy to go back and standardise this a separate commit if there's a preferred format.
Questions: