[Drawer] Hide focus ring #9147
Merged
[Drawer] Hide focus ring #9147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robdodson Please, keep pushing the |
oliviertassinari
added
component: drawer
|
@rodrigofepy Thank you! |
|
In this case, because you're just moving the focus start point into a non-interactive element, I think it's ok to disable the focus outline, especially since the element slides on screen and fades out the background. So long as the user can press tab and reach the first available anchor and see a focus outline on that control, then I think it's fine. |
|
But yeah we're continuing to work on focus-ring :D |
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
* [Drawer] Hide focus ring * Update Drawer.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for giving me the opportunity to make my first PR.
Closes #9144