-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[typescript] Extract WithTheme for external use #9363
Conversation
width?: React.CSSProperties['width'] | ||
breakpoint?: Breakpoint | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what's going on here... you're duplicating the above Theme
declaration but with optional properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, copy paste error. Good thing we have reviews!
fixed |
docs/src/pages/guides/typescript.md
Outdated
merge( | ||
{ | ||
appDrawer: { | ||
width: '225px', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could just be width: 255
🤷♂️
WithTheme
for external useThemeOptions
example in typescript guide