[docs] Fix dark theme toggle of website home page content #9560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
approved these changes
Dec 19, 2017
|
Thanks for raising the issue and your first pull-request here! |
|
@oliviertassinari I tested on multiple browsers and with the line:
I still see the white background when toggling the dark theme. But it does work with the following:
|
|
@Tuaniwan Try it out on a local branch up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the current version of material-ui.com, if you toggle the dark theme, the content area stays white and it's text stays white so the contrast could be better 馃槈
I simply verify if it's the dark theme, change the color proportionally differently from the footer (same proportions as the light version)