[BottomNavigationButton] onClick and onChange handler overwritten #9564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2017 01:23
…onClick prop provided We're not pulling the onClick prop out in the destructure, so when we apply other to ButtonBase, we overwrite the onClick handler. The unit test is evergreen, because it's checking to see if the spy we're passing in is being called when click is simulated, which it is, though not through the handleChange method. To fix this, I've pulled onClick before destructuring. If onClick is provided, it will be invoked in the handleChange class method. I've also added some tests to get BottomNavigationButton to 100% code coverage (part of the effort for #9527).
| @@ -90,14 +90,30 @@ describe('<BottomNavigationButton />', () => { | |||
| assert.strictEqual(iconWrapper.is(Icon), true, 'should be an Icon'); | |||
| }); | |||
|
|
|||
| it('should not render an Icon if icon is not provided', () => { | |||
| const wrapper = shallow(<BottomNavigationButton />); | |||
| assert.isFalse(wrapper.find(Icon).exists()); | |||
There was a problem hiding this comment.
strictEqual(, false) ? O:)
oliviertassinari
added
bug 🐛
|
All set! |
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handler that invokes onChange and onClick will be overwritten if an onClick prop is provided.
We're not pulling the onClick prop out in the destructure, so when we apply other to ButtonBase, we overwrite the onClick handler. The unit test is evergreen, because it's checking to see if the spy we're passing in is being called when click is simulated, which it is, though not through the handleChange method.
To fix this, I've pulled onClick before destructuring. If onClick is provided, it will be invoked in the handleChange class method. I've also added some tests to get BottomNavigationButton to 100% code coverage (part of the effort for #9527).