Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItemText] Add extra class to style secondary text #9759

Merged

Conversation

t49tran
Copy link
Contributor

@t49tran t49tran commented Jan 6, 2018

Add a new attribute textSecondary to ListItemText component classes property.
It allows customising secondary text styles separately from the primary text.

Breaking change

<ListItem
  classes={{
-   text: 'my-class',
+   textPrimary: 'my-class',
  }}
/>

Closes #9223

@oliviertassinari oliviertassinari changed the title Feat/list item text add secondary class [ListItemText] Add extra class to style secondary text Jan 6, 2018
@oliviertassinari oliviertassinari added breaking change component: list This is the name of the generic UI component, not the React module! new feature New feature or request labels Jan 6, 2018
@@ -9,7 +9,7 @@ export interface ListItemTextProps
secondary?: React.ReactNode;
}

export type ListItemTextClassKey = 'root' | 'inset' | 'dense' | 'text' | 'textDense';
export type ListItemTextClassKey = 'root' | 'inset' | 'dense' | 'text' | 'textDense' | 'textSecondary';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'text' -> 'textPrimary'

@oliviertassinari oliviertassinari force-pushed the feat/list-item-text-add-secondary-class branch from edfd6f1 to 0ab2134 Compare January 6, 2018 10:36
@oliviertassinari oliviertassinari merged commit d0d9fd0 into mui:v1-beta Jan 6, 2018
@t49tran t49tran deleted the feat/list-item-text-add-secondary-class branch May 21, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: list This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants