[Tooltip] Zero-length titles string are never displayed #9766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: tooltip
mbrookes
reviewed
Jan 6, 2018
pages/api/tooltip.md
Outdated
| @@ -25,7 +25,7 @@ filename: /src/Tooltip/Tooltip.js | |||
| | open | bool | | If `true`, the tooltip is shown. | | |||
| | placement | enum: 'bottom-end', 'bottom-start', 'bottom', 'left-end', 'left-start', 'left', 'right-end', 'right-start', 'right', 'top-end', 'top-start', 'top'<br> | 'bottom' | Tooltip placement | | |||
| | PopperProps | object | | Properties applied to the `Popper` element. | | |||
| | <span style="color: #31a148">title *</span> | node | | Tooltip title. | | |||
| | <span style="color: #31a148">title *</span> | node | | Tooltip title. zero-length titles string are never displayed. | | |||
oliviertassinari
force-pushed
the
tooltip-empty-title
branch
from
6548a8a
to
dfcfe88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title propType won't warn for an empty title string like in the following example:
It's considered a valid node. However, there is no point at displaying an empty tooltip.
Closes #9714