Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Remove the input warning #9774

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 7, 2018

I have initially added this warning to help user finding wrong usages of our API.
It was an innovation. Before, we were using the muiName to only code branch our rendering tree.
I have been giving more thought about it. It doesn't solve much of the root cause as #9737 has shown. I'm removing the warning here.

Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away. Antoine de Saint-Exupery

Closes #9736

@oliviertassinari oliviertassinari added the component: select This is the name of the generic UI component, not the React module! label Jan 7, 2018
@oliviertassinari oliviertassinari merged commit cc1740c into mui:v1-beta Jan 7, 2018
@oliviertassinari oliviertassinari deleted the select-remove-warning branch January 7, 2018 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant