Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StepButton] Fix TypeScript definition #9796

Merged
merged 1 commit into from Jan 9, 2018
Merged

[StepButton] Fix TypeScript definition #9796

merged 1 commit into from Jan 9, 2018

Conversation

hapood
Copy link
Contributor

@hapood hapood commented Jan 9, 2018 •
edited by oliviertassinari

Orientation should not be a required prop, now it became optional.

And children be React.ReactElement will cause string not assignable to children, refer to ButtonProps remove children in props.

Closes #9782

@oliviertassinari oliviertassinari changed the title [StepButton] Fix typescript (#9782) [StepButton] Fix typescript Jan 9, 2018
@oliviertassinari oliviertassinari added the component: stepper This is the name of the generic UI component, not the React module! label Jan 9, 2018
@oliviertassinari oliviertassinari changed the title [StepButton] Fix typescript [StepButton] Fix TypeScript definition Jan 9, 2018
@oliviertassinari oliviertassinari merged commit 0f6464b into mui:v1-beta Jan 9, 2018
@oliviertassinari
Copy link
Member

@hapood BrowserStack has some load issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hapood @oliviertassinari