Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Improve vertical alignment #9827

Merged
merged 1 commit into from Jan 11, 2018
Merged

[Select] Improve vertical alignment #9827

merged 1 commit into from Jan 11, 2018

Conversation

jedwards1211
Copy link
Contributor

@jedwards1211 jedwards1211 commented Jan 10, 2018

Closes #9826

@jedwards1211
Copy link
Contributor Author

jedwards1211 commented Jan 10, 2018

@oliviertassinari argos thinks there's a visual regression, but this is because the vertical alignment of Selects has been fixed

@jedwards1211 jedwards1211 changed the title fix #9826 [Select] fix vertical alignment (causes argos to complain of visual regression) Jan 10, 2018
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 10, 2018

but this is because the vertical alignment of Selects has been fixed

@jedwards1211 I don't agree, the Argos shouldn't report any diff. The Select vertical alignment is off by some pixels if you compare it with the Input.

@jedwards1211
Copy link
Contributor Author

jedwards1211 commented Jan 10, 2018

@oliviertassinari but the vertical alignment of Selects in master is wrong; it doesn't always match the vertical alignment of Inputs. So the vertical alignment of Selects needs to change and there will have to be a diff in Argos. Does that make sense? However, I see one case where the alignment of the caret is obviously wrong due to my PR.

@jedwards1211
Copy link
Contributor Author

@oliviertassinari it does also appear that before my PR the vertical alignments of all these different types of selects was consistent with each other, even if not consistent with inputs, and my PR has broken the consistency between the different selects. I will fix this in my PR.

@oliviertassinari oliviertassinari changed the title [Select] fix vertical alignment (causes argos to complain of visual regression) [Select] Improve vertical alignment Jan 11, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: select This is the name of the generic UI component, not the React module! labels Jan 11, 2018
@oliviertassinari oliviertassinari self-assigned this Jan 11, 2018
@oliviertassinari oliviertassinari merged commit 21bce6d into mui:v1-beta Jan 11, 2018
@oliviertassinari
Copy link
Member

@jedwards1211 Thank you :)

@jedwards1211
Copy link
Contributor Author

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants