Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Upgrade the dependencies 馃槩 #9828

Merged
merged 1 commit into from Jan 10, 2018
Merged

[core] Upgrade the dependencies 馃槩 #9828

merged 1 commit into from Jan 10, 2018

Conversation

oliviertassinari
Copy link
Member

No description provided.

oliviertassinari
oliviertassinari commented Jan 10, 2018
View reviewed changes
.size-limit
},
{
"path": "test/size/overhead.js",
"limit": "24.4 KB"
"limit": "25.6 KB"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃槩

@oliviertassinari oliviertassinari merged commit c0afa64 into mui:v1-beta Jan 10, 2018
@oliviertassinari oliviertassinari deleted the upgrade-dependencies-v2 branch January 10, 2018 22:47
@oliviertassinari oliviertassinari changed the title [core] Upgrade the dependencies [core] Upgrade the dependencies 馃槩 Jan 14, 2018
@cesardeazevedo
Copy link
Contributor

jss-vendor-prefixer requires jss@9.5.0 and will not work with jss@9.3.3 since the toCssValue function was only exposed on 9.5.0.

I just upgrade to 1.0.0-beta.28 and i got a Uncaught TypeError: (0 , _jss.toCssValue) is not a function, i had to install jss@9.5.0 myself in order to fix it.

Relevant the commits.
https://github.com/cssinjs/jss-vendor-prefixer/commit/a4619ccd7466f0006ddee59bd55c36e88929c531
cssinjs/jss@2d642d9

@oliviertassinari
Copy link
Member Author

@cesardeazevedo Good catch. What about doing the following change:
package.json

-    "jss": "^9.3.3",
+    "jss": "^9.5.0",

@andreapier
Copy link

Same issue here.
Are you going to release a new patch anytime soon?
Or your suggestion for now is to add jss as a dependency (even if not used)?

@cesardeazevedo cesardeazevedo mentioned this pull request Jan 15, 2018
Merged
@cesardeazevedo
Copy link
Contributor

I just created a pull request #9885

djhi added a commit to marmelab/react-admin that referenced this pull request Jan 15, 2018
@djhi
Fix mui version because of mui/material-ui#9828 (comment)
1f51872
djhi added a commit to marmelab/react-admin that referenced this pull request Jan 15, 2018
@djhi
Fix mui version because of mui/material-ui#9828 (comment)
cb83f98
@zannager zannager added the core Infrastructure work going on behind the scenes label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oliviertassinari @cesardeazevedo @andreapier @zannager