[TableCell] Add type property #9852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new property can be used to get a TableCell to be styled as if it was part of a TableHead, TableBody, or TableFooter component. As part of this enhancement, the styles defined in TableHead and TableFooter have been removed and added to their respective classes in TableCell. **Breaking Changes:** - TableHead and TableFooter no longer offer a CSS API, which means their root classes are no longer available. To style this element, a `className` prop can be passed, as all non-API props will be spread to the root element.
oliviertassinari
added
component: table
oliviertassinari
approved these changes
Jan 12, 2018
|
@kgregory Awesome job! It's a great step toward higher customizability. |
oliviertassinari
changed the title
|
The class names for table cells have been changed ( |
|
@ljvanschie A pull-request would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new property can be used to style a
TableCellas if it is part of aTableHead,TableBody, orTableFootercomponent.As part of this enhancement, the styles defined in TableHead and TableFooter have been removed and added to their respective classes in TableCell.
Breaking Changes
TableHead,TableBodyandTableFooterno longer offer a CSS API, which means theirrootclasses are no longer available. To style the root element in these components, aclassNameprop can be passed, as all non-API props will be spread to the root element.