Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GridListTile] Fix error when overriding classes #9862

Merged
merged 2 commits into from Jan 13, 2018
Merged

[GridListTile] Fix error when overriding classes #9862

merged 2 commits into from Jan 13, 2018

Conversation

KevinAsher
Copy link
Contributor

Fixes the overriding of the classes imgFullHeight and imgFullWidth.

Closes #9856

@caub
Copy link
Contributor

caub commented Jan 13, 2018 •
edited

oh css-in-js can generate multiple CSS classes for a style entry? are you sure?

@oliviertassinari oliviertassinari self-assigned this Jan 13, 2018
@oliviertassinari oliviertassinari changed the title Fix error when overriding classes of GridListTile [GridListTile] Fix error when overriding classes Jan 13, 2018
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: image list This is the name of the generic UI component, not the React module! labels Jan 13, 2018
@oliviertassinari
Copy link
Member

@caub withStyles() is concatenating the user class name with the component class name. So yes, you end up with two class names. I have added a failing test case.

@oliviertassinari oliviertassinari merged commit 2ed7304 into mui:v1-beta Jan 13, 2018
@oliviertassinari
Copy link
Member

@KevinAsher Thank you!

@KevinAsher
Copy link
Contributor Author

@oliviertassinari thanks for the fast feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oliviertassinari oliviertassinari

Labels
bug 🐛 Something doesn't work component: image list This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KevinAsher @caub @oliviertassinari