[Icon] Remove icon ligature "magic" support #9983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure this is strictly "core", but there isn't an obvious catch-all label for cross-component changes. |
Expand use of cloneChildrenWithClassName helper Standardise some icon prop naming
oliviertassinari
changed the title
src/Chip/Chip.js
Outdated
| */ | ||
| deleteIcon: PropTypes.element, | ||
| deleteIcon: PropTypes.node, |
There was a problem hiding this comment.
Given we add an extra class. I'm not convinced it's an API we want to support.
oliviertassinari
approved these changes
Jan 22, 2018
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Expand use of cloneChildrenWithClassName helper
Standardise some icon prop descriptions
Closes #9968
Breaking change
We have removed the "magic"
<Icon>wrapping logic. It should be done explicitly now.It's making our components less biased around the svg icon vs font icon choice.