Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[figma] Add more variants to Paper #29

Closed
Nicktho opened this issue Oct 28, 2021 · 3 comments
Closed

[figma] Add more variants to Paper #29

Nicktho opened this issue Oct 28, 2021 · 3 comments
Labels
figma support: question Community support but can be turned into an improvement

Comments

@Nicktho
Copy link

Nicktho commented Oct 28, 2021

Hey there 馃憢 , I love the foundations you have set with version 5 of MUI and the figma file!

For the Paper component in figma, we had to add some more variants to match the settings for the component (https://mui.com/components/paper/). I understand adding all the variations might be tedious, but one that was missing that I think would be useful to add to the file itself is the state where paper can have an elevation of 0 and no outline.

@adrianmanea
Copy link
Collaborator

Hi Nick, thank you for your suggestion. I'm curious, how do you use the Paper component nowadays? Especially with the Auto Layout feature?

@oliviertassinari
Copy link
Member

From what I understand @Nicktho, the elevation is not a prop because it can be customized with the style directly:

Screenshot 2021-10-28 at 15 53 23

@oliviertassinari oliviertassinari added the status: waiting for author Issue with insufficient information label Oct 29, 2021
@Nicktho Nicktho closed this as completed Nov 26, 2021
@oliviertassinari oliviertassinari added support: question Community support but can be turned into an improvement and removed status: waiting for author Issue with insufficient information labels Nov 26, 2021
@Nicktho
Copy link
Author

Nicktho commented Nov 30, 2021

@adrianmanea, Apologies for getting back to you so late. Ideally we would have used the Paper component w/ Auto Layout, but unfortunately due to the constraints of figma's components (not able to nest generic children in component instances), what we end up having to do is detach instances of Paper from the component and go from there.

I also touched on this here: #30 (comment)

Also @oliviertassinari, you're correct, once detached adding effect styles achieves the result we were after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
figma support: question Community support but can be turned into an improvement
Projects
None yet
Development

No branches or pull requests

3 participants