-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[figma] Layout components / Primitives #30
Comments
I don't get it, the React Stack component is meant to replicate this feature: of Figma. |
@Nicktho Did you find a solution to your problem? |
Hey @oliviertassinari, sorry to just close this on you. Auto Layout does implement the main features of Stack that we were looking for, albeit due to limitations of figma we can't force the use of spacing tokens. In my ideal workflow I would have a Similar problems arise with So TLDR, yes we solved it with manual process rather than tooling. |
@Nicktho This is a great point. Maybe we could expose a |
Interesting article. And also interesting you are discussing for react too. In my mind, I modeled this in react using So, to achieve something like <Typography>Hello World</Typography>
<Space y={1} />
<Typography>A New Line</Typography>
<Space y={2} />
<Typography>Another Line</Typography> You would use stacks <Stack spacing={1}>
<Typography>Hello World</Typography>
<Stack spacing={2}>
<Typography>A New Line</Typography>
<Typography>Another Line</Typography>
</Stack>
</Stack> But yeah, until figma supports generic children in components something like this isn't possible with their variants. Adding a spacing component could help though! I think overall an example of a few fleshed out screens using auto layout and the current mui design system in figma would go a long way. |
Interesting suggestion, @Nicktho having a component Spacing which has different levels of widths that acts as spacing (8, 16, 24, etc) that users can use in their Grids. Alternatively, we tried to communicate the spacings to users through a Layout component, https://www.figma.com/file/n7JwXE0hDtjetTmTZ8oaRL/?node-id=7556%3A51279 |
Solved this in the v5.9.0 updates! |
We've been playing around with the figma file and our own solutions to try and implement the ideas from components such as https://mui.com/components/stack/ and the system in general.
We haven't quite nailed it yet, and would love to see an example or two of a complete layout using the figma components that somehow adheres to the system so that designers and developers can align on the design tokens and their settings, especially when it comes to spacing.
The text was updated successfully, but these errors were encountered: