Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass at creating queries+APIs [WIP] #396

Merged
merged 16 commits into from May 19, 2022
Merged

First pass at creating queries+APIs [WIP] #396

merged 16 commits into from May 19, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 10, 2022

Initial pass

@render
Copy link

render bot commented May 10, 2022

@oliviertassinari oliviertassinari temporarily deployed to first-pass-queries - toolpad-db PR #396 May 10, 2022 15:59 — with Render Destroyed
@Janpot Janpot changed the title First pass at creating queries+APIs First pass at creating queries+APIs [WIP] May 10, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 11, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 11, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 14, 2022
@render
Copy link

render bot commented May 16, 2022

Your Render PR Server URL is https://toolpad-pr-396.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ca19shf5f992fsishvmg.

@oliviertassinari oliviertassinari temporarily deployed to first-pass-queries - toolpad-db PR #396 May 16, 2022 18:56 — with Render Destroyed
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 16, 2022
@prakhargupta1
Copy link
Member

A concern that I felt in this version: I can't see add query button option until I create a page. It will be a problem for those who like to establish DB connection and fetch data first.

Like we are showing a Connection by default. I suggest we also show the first blank page by default. This will also make discovery of Components slider easier. Currently, it appears only after the page is created.

@Janpot Janpot mentioned this pull request May 18, 2022
@Janpot Janpot marked this pull request as ready for review May 18, 2022 20:08
@Janpot Janpot merged commit 2630567 into master May 19, 2022
@Janpot Janpot deleted the first-pass-queries branch May 19, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants