Skip to content

Commit

Permalink
remove unnecessary filtering for pinned rows
Browse files Browse the repository at this point in the history
  • Loading branch information
cherniavskii committed Jul 9, 2022
1 parent c9d1fd5 commit 305983b
Showing 1 changed file with 2 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -223,18 +223,8 @@ const DataGridProVirtualScroller = React.forwardRef<
const [leftPinnedColumns, rightPinnedColumns] = filterColumns(pinnedColumns, visibleColumnFields);

const pinnedRows = useGridSelector(apiRef, gridPinnedRowsSelector);

const filterPinnedRows = React.useCallback(
(row) => {
// This is a workaround for the issue when grid tries to render pinned row,
// but pinned rows preprocessing is not done yet and row is missing in `idRowsLookup`
return apiRef.current.unstable_isRowPinned(row.id);
},
[apiRef],
);

const topPinnedRowsData = (pinnedRows?.top || []).filter(filterPinnedRows);
const bottomPinnedRowsData = (pinnedRows?.bottom || []).filter(filterPinnedRows);
const topPinnedRowsData = pinnedRows?.top || [];
const bottomPinnedRowsData = pinnedRows?.bottom || [];

const ownerState = {
classes: rootProps.classes,
Expand Down

0 comments on commit 305983b

Please sign in to comment.