Skip to content

Commit

Permalink
fix bug in suspense
Browse files Browse the repository at this point in the history
  • Loading branch information
cherniavskii committed Apr 11, 2024
1 parent 4db77b1 commit ed31719
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ const GridHeaderFilterCell = React.forwardRef<HTMLDivElement, GridHeaderFilterCe
}
const elementToFocus = focusableElement || cellRef.current;
elementToFocus?.focus();
apiRef.current.columnHeadersContainerElementRef!.current!.scrollLeft = 0;
if (apiRef.current.columnHeadersContainerElementRef?.current) {
apiRef.current.columnHeadersContainerElementRef.current.scrollLeft = 0;
}
}
}, [InputComponent, apiRef, hasFocus, isEditing, isMenuOpen]);

Expand Down
5 changes: 4 additions & 1 deletion packages/grid/x-data-grid-pro/src/utils/domUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ export function findGridCellElementsFromCol(col: HTMLElement, api: GridPrivateAp
}

export function findGridHeader(api: GridPrivateApiPro, field: string) {
const headers = api.columnHeadersContainerElementRef!.current!;
const headers = api.columnHeadersContainerElementRef?.current;
if (!headers) {
return null;
}
return headers.querySelector(`:scope > div > div > [data-field="${field}"][role="columnheader"]`);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ function GridColumnHeaderItem(props: GridColumnHeaderItemProps) {
const focusableElement = headerCellRef.current!.querySelector<HTMLElement>('[tabindex="0"]');
const elementToFocus = focusableElement || headerCellRef.current;
elementToFocus?.focus();
apiRef.current.columnHeadersContainerElementRef!.current!.scrollLeft = 0;
if (apiRef.current.columnHeadersContainerElementRef?.current) {
apiRef.current.columnHeadersContainerElementRef.current.scrollLeft = 0;
}
}
}, [apiRef, hasFocus]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => {
);

React.useEffect(() => {
apiRef.current.columnHeadersContainerElementRef!.current!.scrollLeft = 0;
if (apiRef.current.columnHeadersContainerElementRef?.current) {
apiRef.current.columnHeadersContainerElementRef.current.scrollLeft = 0;
}
}, [apiRef]);

// memoize `getFirstColumnIndexToRender`, since it's called on scroll
Expand Down

0 comments on commit ed31719

Please sign in to comment.