-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should logger log in process.env.NODE_ENV === test? #102
Comments
I think it can log from the info level. So it's less verbose and we can understand a bit more where it fails |
I was looking that the console on the storybook side, the debug and info messages hide the other important warnings and errors. What about the following plan?
|
How about we set the default level to warning? How do you want to opt-in? |
Agree! I was under the assumption that we use
I think that it depends on the use cases. Maybe?
|
Users have the option to pass their own logger, in the case they use a database or something like seq or splunk...
It already does that. If you add DEBUG in your local storage, it overrides the environment conf and start logging. What are we trying to achieve here? |
This would be great :). It would solve the flooding pain point and be enough to close the issue.
Interesting, would it be used for remote debugging? For this use case, I was expecting that developers would hook into the native console calls and record all the events. To make sure they don't miss any from other parts of the UI. |
Well I have not come through the practice of overriding the console to get the component logs. Usually library or component logging get dropped and forgotten as we expect libraries to work... |
I never had this case in the browser, so I can't tell. I also didn't benchmark what alternative UI libraries have for logging. Let's see and explore how that custom logger will turn out :). The closest I was in the past, was with Sentry, they wrap EVERYTHING, we would use the console logs recorded to debug exceptions. On node.js side, I have tried node bunyan but their decoder wasn't forwarding the right system signal for our docker instance cleanup to work correctly. We went with a custom implementation and an adapter for ClouldWatch on AWS. What problem were you solving with Seq? I mean, how was it used to improve the final application? |
It was used in support for example, to track user actions on the app. |
Noticed it with oliviertassinari/material-ui@9a3c143.
The text was updated successfully, but these errors were encountered: