Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] no-response workflow - Next steps #10810

Closed
7 tasks done
michelengelen opened this issue Oct 26, 2023 · 12 comments
Closed
7 tasks done

[core] no-response workflow - Next steps #10810

michelengelen opened this issue Oct 26, 2023 · 12 comments
Labels
core Infrastructure work going on behind the scenes

Comments

@michelengelen
Copy link
Member

michelengelen commented Oct 26, 2023

Additional (nit) tasks discovered:

  • Update query, naming and title for this page in toolpad
  • clean PRs without reviewers (especially all those bump PRs that haven't been merged)

Originally posted by @oliviertassinari in #10491 (comment)

Search keywords:

@michelengelen michelengelen self-assigned this Oct 26, 2023
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 26, 2023
@MBilalShafi MBilalShafi added core Infrastructure work going on behind the scenes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 3, 2023
@oliviertassinari
Copy link
Member

On 2. This would solve cases like #10967 where the status: needs triage comes back to MUI X from Material UI:

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 10, 2023

On 4. also applies to transferred issues, the bot struggles:

@michelengelen
Copy link
Member Author

@oliviertassinari I guess we can move on with this. I haven't heard of any complains so far. Do you agree?

@oliviertassinari
Copy link
Member

@michelengelen Let's go 🚀

@MBilalShafi
Copy link
Member

MBilalShafi commented Dec 7, 2023

There's a small complaint regarding the waiting for maintainer tag being added when the ticket author does a comment and close instead of only doing a comment (in this case the added tag doesn't make sense). It was reported by @LukasTy (example issue: #10657). Though IMO it's an edge case and not a blocker to move forward.

I'll make sure to update the action accordingly and update ASAP, @michelengelen maybe I can also take care of updating the workflow in other repos (point no. 4) afterward unless you already started doing so?

@michelengelen
Copy link
Member Author

@MBilalShafi I was about to be handling this today, but when you are changing the workflow anyways feel free to handle the other repos as well.

I can take over again after the change has been applied then.

point 3. from the description above is already done, but only awaits an approval in mui/mui-public#136

MBilalShafi added a commit to mui/mui-toolpad that referenced this issue Dec 12, 2023
Addresses point # 4 of mui/mui-x#10810

Just before merging this PR, the GitHub label `status: needs more information` should be renamed to `status: waiting for author`, and a new label `status: waiting for maintainer` should be created.

Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
@michelengelen
Copy link
Member Author

@MBilalShafi thanks for taking care of the changes in the other repos! Much appreciated! 🙇🏼

@MBilalShafi
Copy link
Member

You are welcome @michelengelen, thank you too for waiting for the change I had to make in the workflow. 🙏

The Point no 4 is merged to mui-x, material-ui, and mui-toolpad. For mui-public, mui-design-kits, and mui-private, the PRs are ready and have approval too, though I am not sure if it's fine to merge the PRs right now or if we should wait for another approval. Feel free to take over the merging, and taking over the issue on the next points.

@oliviertassinari
Copy link
Member

I did an attempt as 6 in https://www.notion.so/mui-org/Technical-support-80c9c7e0af614af68c1abb7120f634c8.

@michelengelen
Copy link
Member Author

@oliviertassinari nice one! Wanted to ask you what exactly you were expecting with that point to add it later. Thanks for picking this up!

@michelengelen
Copy link
Member Author

All tasks done now! Thanks everyone!

@oliviertassinari
Copy link
Member

I forgot mui-design-kits, fixed in: mui/mui-design-kits@db7ad44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

No branches or pull requests

3 participants