Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Charts] Pie Charts - Allow Percentages for innerRadius / outerRadius #11309

Closed
johnsonav1992 opened this issue Dec 4, 2023 · 8 comments 路 Fixed by #11464
Closed

[Charts] Pie Charts - Allow Percentages for innerRadius / outerRadius #11309

johnsonav1992 opened this issue Dec 4, 2023 · 8 comments 路 Fixed by #11464
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@johnsonav1992
Copy link

johnsonav1992 commented Dec 4, 2023

Summary 馃挕

As of now, Mui-X Pie charts that are being turned into donut charts via innerRadius and outerRadius cannot use percentages for these two properties (among other properties not listed here that only take numbers and not percentages that would also benefit from being able to take percentages). Because of this, when using a responsive chart, the width of the donut arc changes because the inner / outer radii are not scaling with the size of the donut.

Examples 馃寛

Current functionality

Screen-Recording-2023-12-04-at-1

Desired Functionality

Screen-Recording-2023-12-04-at-1 (1)

Motivation 馃敠

We currently cannot fully migrate from our current charting library because of a couple of basic, missing features from Mui-X-Charts, this being one of them.

Search keywords: Pie Chart Inner Radius
Order ID: 73086

@johnsonav1992 johnsonav1992 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 4, 2023
@johnsonav1992 johnsonav1992 changed the title Pie Charts - Allow Percentages for innerRadius / outerRadius [Charts] Pie Charts - Allow Percentages for innerRadius / outerRadius Dec 4, 2023
@michelengelen michelengelen added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! status: needs triage labels Dec 5, 2023
@michelengelen
Copy link
Member

Hey @alexfauquette ... this is one for you to look at! 馃挭馃徏

Thanks 馃檱馃徏

@alexfauquette alexfauquette removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 5, 2023
@johnsonav1992
Copy link
Author

@alexfauquette What's the status on this? Thank you!

@alexfauquette
Copy link
Member

It's in the TODO I assume should arrive around the end of the month, depending on the difficulty to add it, and the review cycle

@johnsonav1992
Copy link
Author

It's in the TODO I assume should arrive around the end of the month, depending on the difficulty to add it, and the review cycle

Thank you, sir!

@alexfauquette
Copy link
Member

@johnsonav1992 I tried a very rough reproduction of your usecase with this PR build #11464 Do I miss something?

https://codesandbox.io/p/sandbox/async-wildflower-yhklwf?file=%2Fsrc%2FDemo.tsx%3A30%2C23

resize.mp4

@johnsonav1992
Copy link
Author

@alexfauquette Sorry for the delay! I have been on a holiday break. That is exactly it! Greatly appreciate you working on this. Was this merged PR released yet or is it coming in a future release?

@LukasTy
Copy link
Member

LukasTy commented Jan 2, 2024

@johnsonav1992 It has been included in the latest 6.18.4 release. 馃槈

@johnsonav1992
Copy link
Author

@LukasTy Just checked and I see it now! Thank you guys! Appreciate all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants