[charts] Allow percentage values for pie chart center and radius #11464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-11464--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Dec 21, 2023
|
@alexfauquette Appreciate you, sir! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11309
The inner radius value for 100% is the maximal radius.
My initial idea was to take:
This would ensure that the inner radius is always smaller than the outer radius.
But if you want to put multiple pie charts inside each other, you will need to do some computation to get the outer radius of one pie to match the inner radius of the other one.
The percentage is supported only at the
PiePlotlevel. To place sub-components you already need to manipulate the drawing area, so the diff between having to computewidth/2vs providing'50%'is small enough to remove percent support