Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Incorrect table height if height is inherited #13536

Closed
1 task done
ithrforu opened this issue Jun 19, 2024 · 12 comments
Closed
1 task done

[data grid] Incorrect table height if height is inherited #13536

ithrforu opened this issue Jun 19, 2024 · 12 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: css Design CSS customizability feature: Rendering layout Related to the data grid Rendering engine support: commercial Support request from paid users support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@ithrforu
Copy link
Contributor

ithrforu commented Jun 19, 2024

Search keywords

height="100%", flex-grow="1", flexGrow="1", table height, table flex height, inherited height

Latest version

  • I have tested the latest version

Link to live examples:

Current behavior

Table does not adjust to page height if height is inherited (the entire page has scrolling): latest.webm.

Expected behavior

Table adjust to page height if height is inherited (only table has scrolling): 6-2-0.webm.

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID or Support key 💳 (optional)

72020

@ithrforu ithrforu added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 19, 2024
@michelengelen
Copy link
Member

Hey @ithrforu the latest version link is not working (sandbox is not public) ... could you update that please? Thanks!

@michelengelen michelengelen added component: data grid This is the name of the generic UI component, not the React module! status: waiting for author Issue with insufficient information feature: Rendering layout Related to the data grid Rendering engine customization: css Design CSS customizability and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 19, 2024
@michelengelen michelengelen changed the title Incorrect table height if height is inherited [data grid] Incorrect table height if height is inherited Jun 19, 2024
@michelengelen michelengelen added support: commercial Support request from paid users support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/ labels Jun 19, 2024
@ithrforu
Copy link
Contributor Author

@michelengelen, hey!
Thanks, I updated the link.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Jun 20, 2024
@michelengelen
Copy link
Member

This seems like a problem with the Box component.
When you remove the wrapping <Box flexGrow={1}> it works as expected: DEMO

@mnajdova WDYT?

@ithrforu
Copy link
Contributor Author

ithrforu commented Jun 20, 2024

Yes, but i need <Box flexGrow={1}> (more often Stack) for another layout above a table.

@michelengelen
Copy link
Member

Ok, found a solution.
<Box flexGrow={1} sx={{ minHeight: 0 }}> works perfectly fine! :D

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 20, 2024
@ithrforu
Copy link
Contributor Author

@michelengelen, thanks, thats works.

But why its broken in 6.2.1?

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Jun 21, 2024
@michelengelen
Copy link
Member

Not sure why ... let me check

@michelengelen
Copy link
Member

probably due to #8091

@michelengelen
Copy link
Member

but, since this issue is fixed (or at least with a reasonable workaround) I will close it here!

@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 21, 2024
Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@ithrforu: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@ithrforu
Copy link
Contributor Author

@michelengelen, yes, i watched #8091, but still don't understand the reason.

I'd like to figure it out.

@ithrforu
Copy link
Contributor Author

@michelengelen, 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: css Design CSS customizability feature: Rendering layout Related to the data grid Rendering engine support: commercial Support request from paid users support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/
Projects
None yet
Development

No branches or pull requests

2 participants