[DataGrid] Replace GridAutoSizer with ResizeObserver
#8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
added
the
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8091--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
m4theushw
force-pushed
the
resize-observer
branch
from
49f35b7
to
ca35bb0
Compare
m4theushw
commented
Mar 21, 2023
|
|
||
| return ( | ||
| <div ref={ref} {...props}> |
There was a problem hiding this comment.
This DIV is useless.
Comment on lines
+265
to
+268
| setContainerDimensions({ | ||
| width: rootRef.current.clientWidth, | ||
| height: rootRef.current.clientHeight, | ||
| }); |
| @@ -14,8 +14,8 @@ const StyledBox = styled(Box, { | |||
| padding: theme.spacing(1), | |||
| justifyContent: 'center', | |||
| ...(isDataGridTest && { | |||
| width: 500, | |||
There was a problem hiding this comment.
There was a regression test failing for no reason: https://app.circleci.com/pipelines/github/mui/mui-x/35345/workflows/1608837d-fb6c-4adf-bc68-74b2d338dc00/jobs/202833
It seems that the width changed to 0 during the test. I couldn't simulate this outside the test environment. The way I found to fix it was forcing the container width.
DanailH
approved these changes
Mar 23, 2023
|
@m4theushw I thing something is wrong when i use datagrid with autoHeight prop. |
|
@michGreg Can you open an issue with a reproduction example? |
2 tasks
Closed
2 tasks
2 tasks
2 tasks
2 tasks
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7297
Fixes #7956