Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Filtering a column and then selecting all rows, selects even the hidden rows #1707

Closed
2 tasks
taskmonk opened this issue May 19, 2021 · 5 comments
Closed
2 tasks
Labels
component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@taskmonk
Copy link

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

When a column is filtered, on clicking select all checkbox, only the filtered rows should be selected. Currently it selects all rows

Expected Behavior 🤔

newSelection.selectionModel should contain only the filtered rows instead of all rows

Steps to Reproduce 🕹

Steps:

Context 🔦

Your Environment 🌎

`npx @material-ui/envinfo`
  Don't forget to mention which browser you used.
  Output from `npx @material-ui/envinfo` goes here.
@eps1lon eps1lon transferred this issue from mui/material-ui May 19, 2021
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label May 19, 2021
@taskmonk
Copy link
Author

If this issue has already been addressed, can you add the issue link here please?

@oliviertassinari
Copy link
Member

oliviertassinari commented May 22, 2021

@taskmonk I was expecting @mui-org/x to close with the correct duplicated issue. I'm doing it now.

@oliviertassinari
Copy link
Member

Duplicate of #1141

@oliviertassinari oliviertassinari marked this as a duplicate of #1141 May 22, 2021
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label May 22, 2021
@taskmonk
Copy link
Author

Thanks! But this issue is not fixed there either. Any timeline on when the fix would be available?

@oliviertassinari
Copy link
Member

@taskmonk we have no timeline we can communicate on. We might not even implement the behavior you expect, but leave it to developers to control the selection to make it happen. We don't have yet enough information on how end users expect this to behave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants