Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove dependency on @mui/styles #2991

Closed
2 tasks done
DanailH opened this issue Oct 26, 2021 · 0 comments 路 Fixed by #3769
Closed
2 tasks done

[docs] Remove dependency on @mui/styles #2991

DanailH opened this issue Oct 26, 2021 · 0 comments 路 Fixed by #3769
Assignees
@m4theushw
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation

Comments

@DanailH
Copy link
Member

DanailH commented Oct 26, 2021 •
edited by oliviertassinari

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 馃挕

Update the documentation examples in all DataGrid pages as well as in the x-grid-data-generator package, storybook examples, and test cases to use styled (the new way of customizing styles from v5) instead of makeStyles.

Remove all @mui/styles imports.

https://github.com/mui-org/material-ui-x/blob/b7fb0169f74cec58817e85ff167d197a244d6652/package.json#L72

https://github.com/mui-org/material-ui-x/blob/6efc5f9f6f49e9a0566e048b2358cf204abc5753/docs/src/pages/components/data-grid/events/CatalogOfEventsNoSnap.js#L13
@DanailH DanailH added docs Improvements or additions to the documentation status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 26, 2021
@m4theushw m4theushw removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 5, 2021
@m4theushw m4theushw mentioned this issue Nov 24, 2021
Merged
@m4theushw m4theushw self-assigned this Nov 24, 2021
@m4theushw m4theushw mentioned this issue Jan 7, 2022
Merged
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jan 7, 2022
@oliviertassinari oliviertassinari changed the title [docs] Updated docs examples to use styled instead of makeStyles [docs] Remove dependency on @mui/styles Jan 7, 2022
@oliviertassinari oliviertassinari mentioned this issue Jan 7, 2022
Closed
2 tasks
@m4theushw m4theushw mentioned this issue Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4theushw m4theushw

Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[core] Remove remaining usages of @mui/styles m4theushw/mui-x
3 participants
@oliviertassinari @DanailH @m4theushw