Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove remaining usages of @mui/styles #3769

Merged
merged 2 commits into from
Jan 31, 2022
Merged

[core] Remove remaining usages of @mui/styles #3769

merged 2 commits into from
Jan 31, 2022

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Jan 28, 2022 •
edited
Loading

Closes #2991

The file @mui/monorepo/docs/pages/_document still depends on it so we can't remove @mui/styles from docs/package.json yet.

@mui-bot
Copy link

mui-bot commented Jan 28, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 1,121.7 2,039.1 1,380.4 1,521.38 370.527
Sort 100k rows ms 712.9 1,278.3 712.9 985.9 235.663
Select 100k rows ms 188.9 293.4 250.7 246.12 38.969
Deselect 100k rows ms 139.6 231.2 200.8 194.4 32.163

Generated by 🚫 dangerJS against 88fdeaf

@m4theushw m4theushw marked this pull request as ready for review January 28, 2022 19:18
@m4theushw m4theushw added the core Infrastructure work going on behind the scenes label Jan 28, 2022
@m4theushw m4theushw merged commit 9204d7a into mui:master Jan 31, 2022
@m4theushw m4theushw deleted the remove-mui-styles branch January 31, 2022 22:07
@m4theushw m4theushw mentioned this pull request Feb 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Remove dependency on @mui/styles
3 participants
@m4theushw @mui-bot @flaviendelangle