Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] ErrorOverlay not visible with autoHeight #4088

Closed
2 tasks done
marek-saji opened this issue Mar 4, 2022 · 2 comments · Fixed by #4110
Closed
2 tasks done

[DataGrid] ErrorOverlay not visible with autoHeight #4088

marek-saji opened this issue Mar 4, 2022 · 2 comments · Fixed by #4110
Assignees
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine

Comments

@marek-saji
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

When using <DataGrid autoHeight> error overlay is not visible.

Expected behavior 🤔

Error overlay should dictate grid’s height when grid has autoHeight property.

Steps to reproduce 🕹

<DataGrid error autoHeight />

https://codesandbox.io/s/datagriddemo-material-demo-forked-2t3we4?file=/demo.tsx

Context 🔦

No response

Your environment 🌎

Tested on Chrome 98 and Firefox 97 on Linux and Safari 13.1.2 on macOS.

npx @mui/envinfo
  System:
    OS: Linux 5.13 Ubuntu 21.10 21.10 (Impish Indri)
  Binaries:
    Node: 16.13.1 - ~/local/src/nvs/node/16.13.1/x64/bin/node
    Yarn: 1.22.17 - ~/local/src/nvs/node/16.13.1/x64/bin/yarn
    npm: 8.5.1 - ~/local/src/nvs/node/16.13.1/x64/bin/npm
  Browsers:
    Chrome: 98.0.4758.102
    Firefox: 97.0
  npmPackages:
    @emotion/react: latest => 11.8.1 
    @emotion/styled: latest => 11.8.1 
    @mui/base:  5.0.0-alpha.70 
    @mui/material: latest => 5.4.4 
    @mui/private-theming:  5.4.4 
    @mui/styled-engine:  5.4.4 
    @mui/system:  5.4.4 
    @mui/types:  7.1.2 
    @mui/utils:  5.4.4 
    @mui/x-data-grid: latest => 5.5.1 
    @types/react: latest => 17.0.39 
    react: latest => 17.0.2 
    react-dom: latest => 17.0.2 
    typescript: latest => 4.6.2 

Order ID 💳 (optional)

No response

@marek-saji marek-saji added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 4, 2022
@alexfauquette alexfauquette added bug 🐛 Something doesn't work plan: Community component: data grid This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 4, 2022
@alexfauquette
Copy link
Member

In the past, the error was occurring in a different way, the error message was visible but not the Grid. In PR #2946 the overflow style has been modified to hidden so the message does not appear anymore

To fix this bug we will have to rework the GridErrorHandler component to let it works with autoHeight=true

@cherniavskii
Copy link
Member

Hey @marek-saji
Thanks for a great reproduction example!
It looks like error overlay never worked well with autoHeight.
Recently I worked on improving custom overlays in #3832 and it can be related.
I will take a look into this.

@cherniavskii cherniavskii self-assigned this Mar 5, 2022
@cherniavskii cherniavskii added feature: Rendering layout Related to the data grid Rendering engine and removed feature: Other labels Mar 5, 2022
@cherniavskii cherniavskii changed the title DataGrid’s ErrorOverlay not visible with autoHeight [DataGrid] ErrorOverlay not visible with autoHeight Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants