Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Allow print export for more than 100 rows #10045

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Aug 16, 2023

Fixes #3154

Options that were available:

  1. Limit print export to 100 rows and add an explicit warning (would not work great with "Free Forever" MIT licensing, or would it? 🤔 CC @joserodolfofreitas)
  2. ✅ Make Grid think during the export that it doesn't have 100 rows per page restriction (by modifying the signature prop manually, isn't very clean, but works)

Let me know if you have other ideas in mind.

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Export labels Aug 16, 2023
@mui-bot
Copy link

mui-bot commented Aug 16, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10045--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -199.6 105.6 -87 -55.76 128.074
Sort 100k rows ms 753.2 1,494.1 1,327.8 1,211.92 252.13
Select 100k rows ms 671.1 798.7 730.2 735.88 53.6
Deselect 100k rows ms 112.8 224.2 190.6 185.48 39.467

Generated by 🚫 dangerJS against 76d40f4

@MBilalShafi MBilalShafi marked this pull request as ready for review August 16, 2023 05:45
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea 👍

@MBilalShafi MBilalShafi merged commit 6d25c3e into mui:master Aug 17, 2023
17 checks passed
@MBilalShafi MBilalShafi deleted the print-export-100-limit branch August 17, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Print Export of DataGrid asks for Pro License when useState is passed as pageSize
4 participants