Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Name test suites according to sentence case #10429

Merged
merged 2 commits into from
Sep 22, 2023
Merged

[test] Name test suites according to sentence case #10429

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ac2482
[test] Name test suites according to sentence case
alexfauquette Sep 22, 2023
19f905a
Apply suggestions from code review
alexfauquette Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-premium/src/tests/DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { getColumnValues } from 'test/utils/helperFn';

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGrid /> - Quick Filter', () => {
describe('<DataGrid /> - Quick filter', () => {
const { render } = createRenderer();

const baselineProps = {
Expand Down
4 changes: 2 additions & 2 deletions packages/grid/x-data-grid-premium/src/tests/aggregation.DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ describe('<DataGridPremium /> - Aggregation', () => {
});
});

describe('Tree Data', () => {
describe('Tree data', () => {
function TreeDataTest(props: Omit<DataGridPremiumProps, 'columns'>) {
return (
<Test
Expand Down Expand Up @@ -355,7 +355,7 @@ describe('<DataGridPremium /> - Aggregation', () => {
});
});

describe('Column Menu', () => {
describe('Column menu', () => {
it('should render select on aggregable column', () => {
render(<Test />);

Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-premium/src/tests/exportExcel.DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { spyApi } from 'test/utils/helperFn';

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGridPremium /> - Export Excel', () => {
describe('<DataGridPremium /> - Export excel', () => {
alexfauquette marked this conversation as resolved.
Show resolved Hide resolved
const { render } = createRenderer({ clock: 'fake' });

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-premium/src/tests/rowGrouping.DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ const baselineProps: DataGridPremiumProps = {
],
};

describe('<DataGridPremium /> - Row Grouping', () => {
describe('<DataGridPremium /> - Row grouping', () => {
const { render, clock } = createRenderer();

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-premium/src/tests/statePersistence.DataGridPremium.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const FULL_INITIAL_STATE: GridInitialState = {
},
};

describe('<DataGridPremium /> - State Persistence', () => {
describe('<DataGridPremium /> - State persistence', () => {
const { render } = createRenderer();

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/cellEditing.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { getBasicGridData } from '@mui/x-data-grid-generator';
import { createRenderer, fireEvent, act, userEvent } from '@mui/monorepo/test/utils';
import { getCell, spyApi } from 'test/utils/helperFn';

describe('<DataGridPro /> - Cell Editing', () => {
describe('<DataGridPro /> - Cell editing', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/columnHeaders.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getColumnHeaderCell, getColumnValues } from 'test/utils/helperFn';

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGridPro /> - Column Headers', () => {
describe('<DataGridPro /> - Column headers', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

const baselineProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/columnSpanning.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getActiveCell, getCell, getColumnHeaderCell } from 'test/utils/helperFn

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGridPro /> - Column Spanning', () => {
describe('<DataGridPro /> - Column spanning', () => {
const { render } = createRenderer({ clock: 'fake' });

const baselineProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/columnsVisibility.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const rows: GridRowsProp = [{ id: 1 }];

const columns: GridColDef[] = [{ field: 'id' }, { field: 'idBis' }];

describe('<DataGridPro /> - Columns Visibility', () => {
describe('<DataGridPro /> - Columns visibility', () => {
const { render } = createRenderer({ clock: 'fake' });

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/editComponents.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const generateDate = (
return rawDate.getTime();
};

describe('<DataGridPro /> - Edit Components', () => {
describe('<DataGridPro /> - Edit components', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/events.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { spy } from 'sinon';

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGridPro /> - Events Params', () => {
describe('<DataGridPro /> - Events params', () => {
const { render, clock } = createRenderer();

const baselineProps: { rows: GridRowsProp; columns: GridColDef[] } = {
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/rowEditing.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { getBasicGridData } from '@mui/x-data-grid-generator';
import { createRenderer, fireEvent, act, userEvent, screen } from '@mui/monorepo/test/utils';
import { getCell, getRow, spyApi } from 'test/utils/helperFn';

describe('<DataGridPro /> - Row Editing', () => {
describe('<DataGridPro /> - Row editing', () => {
const { render, clock } = createRenderer();

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/rowSelection.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ function getSelectedRowIds() {
);
}

describe('<DataGridPro /> - Row Selection', () => {
describe('<DataGridPro /> - Row selection', () => {
const { render } = createRenderer();

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/statePersistence.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const FULL_INITIAL_STATE: GridInitialState = {
},
};

describe('<DataGridPro /> - State Persistence', () => {
describe('<DataGridPro /> - State persistence', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid-pro/src/tests/treeData.DataGridPro.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const baselineProps: DataGridProProps = {
getRowId: (row) => row.name,
};

describe('<DataGridPro /> - Tree Data', () => {
describe('<DataGridPro /> - Tree data', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

let apiRef: React.MutableRefObject<GridApi>;
Expand Down
4 changes: 2 additions & 2 deletions packages/grid/x-data-grid/src/tests/columnHeaders.DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getColumnHeaderCell, getColumnHeadersTextContent } from 'test/utils/hel

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGrid /> - Column Headers', () => {
describe('<DataGrid /> - Column headers', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

const baselineProps = {
Expand Down Expand Up @@ -50,7 +50,7 @@ describe('<DataGrid /> - Column Headers', () => {
});
});

describe('Column Menu', () => {
describe('Column menu', () => {
it('should allow to hide column', () => {
render(
<div style={{ width: 300, height: 300 }}>
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid/src/tests/columnSpanning.DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getCell, getActiveCell, getColumnHeaderCell } from 'test/utils/helperFn

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGrid /> - Column Spanning', () => {
describe('<DataGrid /> - Column spanning', () => {
const { render, clock } = createRenderer({ clock: 'fake' });

const baselineProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid/src/tests/columnsVisibility.DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const rows: GridRowsProp = [{ id: 1, idBis: 1 }];

const columns: GridColDef[] = [{ field: 'id' }, { field: 'idBis' }];

describe('<DataGridPro /> - Columns Visibility', () => {
describe('<DataGridPro /> - Columns visibility', () => {
const { render } = createRenderer();

function TestDataGrid(
Expand Down
4 changes: 2 additions & 2 deletions packages/grid/x-data-grid/src/tests/layout.DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { useBasicDemoData } from '@mui/x-data-grid-generator';
import { createTheme, ThemeProvider } from '@mui/material/styles';
import { getColumnHeaderCell, getColumnValues, getCell, getRow, sleep } from 'test/utils/helperFn';

describe('<DataGrid /> - Layout & Warnings', () => {
describe('<DataGrid /> - Layout & warnings', () => {
const { clock, render } = createRenderer();

const baselineProps = {
Expand All @@ -35,7 +35,7 @@ describe('<DataGrid /> - Layout & Warnings', () => {
columns: [{ field: 'brand' }],
};

describe('immutable rows', () => {
describe('Immutable rows', () => {
LukasTy marked this conversation as resolved.
Show resolved Hide resolved
alexfauquette marked this conversation as resolved.
Show resolved Hide resolved
it('should throw an error if rows props is being mutated', () => {
expect(() => {
// We don't want to freeze baselineProps.rows
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid/src/tests/quickFiltering.DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { getColumnValues, sleep } from 'test/utils/helperFn';

const isJSDOM = /jsdom/.test(window.navigator.userAgent);

describe('<DataGrid /> - Quick Filter', () => {
describe('<DataGrid /> - Quick filter', () => {
const { render, clock } = createRenderer();

const baselineProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/grid/x-data-grid/src/tests/rowSelection.DataGrid.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function getSelectedRowIds() {
);
}

describe('<DataGrid /> - Row Selection', () => {
describe('<DataGrid /> - Row selection', () => {
const { render, clock } = createRenderer();

const defaultData = getBasicGridData(4, 2);
Expand Down
Loading