Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add reference links to DatePicker components #10626

Merged
merged 7 commits into from
Oct 16, 2023
Merged

[pickers] Add reference links to DatePicker components #10626

merged 7 commits into from
Oct 16, 2023

Conversation

michelengelen
Copy link
Member

This adds Demo and API links to the export for DatePicker, DesktopDatePicker, MobileDatePicker and StaticDatePicker components

It's part of a series to solve #9226

@michelengelen michelengelen added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Oct 10, 2023
@michelengelen michelengelen requested a review from a team October 10, 2023 10:07
@michelengelen michelengelen self-assigned this Oct 10, 2023
@mui-bot
Copy link

mui-bot commented Oct 10, 2023 •
edited

Deploy preview: https://deploy-preview-10626--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 70c3ad1

@michelengelen michelengelen mentioned this pull request Oct 10, 2023
Closed
1 task
@michelengelen
Copy link
Member Author

closing this for now. Reason: #9226 (comment)

@michelengelen michelengelen reopened this Oct 12, 2023
LukasTy
LukasTy approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job! 👏
I'm not sure about the best prefix and labels for these PRs though... 🤷
Technically, they are maybe more of a [pickers] or [core] related than docs, because after these changes there will be 0 changes to the documentation page and we do add [docs] prefix for PRs altering something in the documentation. 🤔

packages/x-date-pickers/src/DatePicker/DatePicker.tsx
* - [Validation](https://mui.com/x/react-date-pickers/validation/)
*
* API:
*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I've tested, this new line is optional. Adding only the new line after Demos seems to solve the problem, but it won't hurt having it here as well. 👌

@michelengelen
Copy link
Member Author

LGTM, good job! 👏 I'm not sure about the best prefix and labels for these PRs though... 🤷 Technically, they are maybe more of a [pickers] or [core] related than docs, because after these changes there will be 0 changes to the documentation page and we do add [docs] prefix for PRs altering something in the documentation. 🤔

Good question. Technically it is documentation, just not on the docs page. 🤷🏼
I guess this can be changed to either one of your suggestions.

@mui/x Thoughts?

@michelengelen michelengelen changed the title [docs] Add reference links to DatePicker components [pickers] Add reference links to DatePicker components Oct 13, 2023
@michelengelen michelengelen merged commit 9dfb3c1 into mui:master Oct 16, 2023
18 checks passed
@michelengelen michelengelen deleted the 9226/date-pickers branch October 16, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle left review comments

@cherniavskii cherniavskii cherniavskii left review comments

@alexfauquette alexfauquette alexfauquette left review comments

@LukasTy LukasTy LukasTy approved these changes

Assignees

@michelengelen michelengelen

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@michelengelen @mui-bot @flaviendelangle @LukasTy @cherniavskii @alexfauquette