[test] Speed-up rebuild in karma #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
reviewed
Feb 17, 2021
| @@ -1,6 +1,8 @@ | |||
| const path = require('path'); | |||
| const webpack = require('webpack'); | |||
|
|
|||
| const CI = Boolean(process.env.CI); | |||
There was a problem hiding this comment.
I would rename the var to isCI has boolean convention isSomething | hasItem
There was a problem hiding this comment.
I'm not aware we have a convention for naming boolean. I believe, so far, we have used them interchangeably. Often omitting is.
Here I think that we should aim toward importing the config file from the mono repo so we don't have to bring improvements like this manually.
dtassone
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage mui/material-ui#24967
Before
After
@eps1lon I have tested the changes in this repo, definitely works 馃槏. We save 2s for each iteration.