[charts] Add reference links to shared/misc chart components #10660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
docs
1 task
|
Deploy preview: https://deploy-preview-10660--material-ui-x.netlify.app/ |
michelengelen
changed the title
alexfauquette
approved these changes
Oct 27, 2023
Comment on lines
91
to
94
| * - [Bars demonstration](https://mui.com/x/react-charts/bar-demo/) | ||
| * - [Lines demonstration](https://mui.com/x/react-charts/line-demo/) | ||
| * - [Area demonstration](https://mui.com/x/react-charts/area-demo/) | ||
| * - [Pie demonstration](https://mui.com/x/react-charts/pie-demo/) |
There was a problem hiding this comment.
Suggested change
| * - [Bars demonstration](https://mui.com/x/react-charts/bar-demo/) | |
| * - [Lines demonstration](https://mui.com/x/react-charts/line-demo/) | |
| * - [Area demonstration](https://mui.com/x/react-charts/area-demo/) | |
| * - [Pie demonstration](https://mui.com/x/react-charts/pie-demo/) | |
| * - [Bars demonstration](https://mui.com/x/react-charts/bars/) | |
| * - [Lines demonstration](https://mui.com/x/react-charts/lines/) | |
| * - [Pie demonstration](https://mui.com/x/react-charts/pie/) |
There was a problem hiding this comment.
I tend to think it's better to link people chare their is some explanation. But might be wrong
| /** | ||
| * API: | ||
| * | ||
| * - [DrawingProvider API](https://mui.com/x/api/charts/drawing-provider/) |
There was a problem hiding this comment.
Why not, but there is a lot to do for those pages to be readable 🫣
There was a problem hiding this comment.
I know ... but we have it in place once its ready, aye? 🏴☠️
There was a problem hiding this comment.
Ho yes, I agree with putting them. it was more to be sure you're also aware about it :)
michelengelen
force-pushed
the
9226/charts-shared
branch
from
3fc1a63
to
977eeab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Demo and API links to the component annotation for ...
CartesianContextProviderChartsAxisChartsXAxisChartsYAxisDrawingProviderChartsTooltipChartsClipPathChartsAxisHighlight... components
It's part of a series to solve #9226