-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Customization Playground - fix DesktopDatePicker sx props examples #10665
Conversation
Deploy preview: https://deploy-preview-10665--material-ui-x.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice observation and fix! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks great! 🙌
Noticed one layout shifting nitpick. 🙈
related to #10657
When styling the elements within the popper of
DesktopDatePicker
with thesx
prop, this needs to be passed to one of the parents of the styled element in order for it to be targeted. I updated the code examples for this. However, it is a workaround-ish solution, so I flagged it with 'warning' and left a comment in the code.