Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Customization Playground - fix DesktopDatePicker sx props examples #10665

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

noraleonte
Copy link
Contributor

related to #10657

When styling the elements within the popper of DesktopDatePicker with the sx prop, this needs to be passed to one of the parents of the styled element in order for it to be targeted. I updated the code examples for this. However, it is a workaround-ish solution, so I flagged it with 'warning' and left a comment in the code.

@noraleonte noraleonte added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Oct 13, 2023
@noraleonte noraleonte self-assigned this Oct 13, 2023
@mui-bot
Copy link

mui-bot commented Oct 13, 2023

Deploy preview: https://deploy-preview-10665--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b8c56df

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice observation and fix! 👍

docs/data/date-pickers/date-picker/examplesConfig.ts Outdated Show resolved Hide resolved
docs/data/date-pickers/date-picker/examplesConfig.ts Outdated Show resolved Hide resolved
docs/src/modules/utils/useCustomizationPlayground.tsx Outdated Show resolved Hide resolved
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks great! 🙌
Noticed one layout shifting nitpick. 🙈

Screen.Recording.2023-10-17.at.10.24.46.mov

docs/src/modules/utils/useCustomizationPlayground.tsx Outdated Show resolved Hide resolved
@noraleonte noraleonte merged commit be453d2 into mui:master Oct 18, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants