Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Allow passing readonly arrays to columns and sortingOrder props #10686

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[DataGrid] Allow passing readonly arrays to columns and sortingOrder props #10686

merged 1 commit into from
Oct 19, 2023

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Oct 15, 2023

Fixes #10685

@mui-bot
Copy link

mui-bot commented Oct 15, 2023 •
edited

Deploy preview: https://deploy-preview-10686--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1e928dc

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Oct 16, 2023
@cherniavskii cherniavskii added typescript dx Related to developers' experience labels Oct 19, 2023
cherniavskii
cherniavskii approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@cherniavskii cherniavskii changed the title [DataGrid] Use readonly array types in the component props. [DataGrid] Allow passing readonly arrays to columns and sortingOrder props Oct 19, 2023
@cherniavskii cherniavskii merged commit 391351c into mui:master Oct 19, 2023
21 checks passed
@pcorpet pcorpet deleted the readonlyprops branch November 1, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] readonly array props
4 participants
@pcorpet @mui-bot @cherniavskii @zannager