Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Fix size aggregation to ignore undefined values #10745

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[DataGridPremium] Fix size aggregation to ignore undefined values #10745

merged 3 commits into from
Oct 23, 2023

Conversation

cherniavskii
Copy link
Member

Fixes #10744

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature labels Oct 20, 2023
@mui-bot
Copy link

mui-bot commented Oct 20, 2023 •
edited

Deploy preview: https://deploy-preview-10745--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 64b609b

@cherniavskii cherniavskii changed the title [DataGridPremium] Fix sum aggregation to ignore undefined values [DataGridPremium] Fix size aggregation to ignore undefined values Oct 23, 2023
@cherniavskii cherniavskii marked this pull request as ready for review October 23, 2023 10:10
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 23, 2023
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 23, 2023
MBilalShafi
MBilalShafi approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@cherniavskii cherniavskii merged commit 5ccb1b1 into mui:master Oct 23, 2023
18 checks passed
@cherniavskii cherniavskii deleted the fix-size-aggregation branch October 23, 2023 20:58
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Nov 6, 2023
@cherniavskii @alexfauquette
[DataGridPremium] Fix size aggregation to ignore undefined values (…
10212fd 
…mui#10745)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Aggregation Related to the data grid Aggregation feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[datagrid] Size aggregation counts undefined values
3 participants
@cherniavskii @mui-bot @MBilalShafi