Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Fix cell selection throwing index error on second page and beyond #10784

Merged
merged 4 commits into from
Oct 24, 2023
Merged

[DataGridPremium] Fix cell selection throwing index error on second page and beyond #10784

merged 4 commits into from
Oct 24, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Oct 23, 2023 •
edited

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Cell Selection Related to the cell selection feature labels Oct 23, 2023
@MBilalShafi MBilalShafi mentioned this pull request Oct 23, 2023
Closed
@mui-bot
Copy link

mui-bot commented Oct 23, 2023 •
edited

Deploy preview: https://deploy-preview-10784--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 25b62c8

@MBilalShafi MBilalShafi changed the title [DataGridPremium] Fix cell selection throwing index error from pages 1 and beyond [DataGridPremium] Fix cell selection throwing index error on second page and beyond Oct 23, 2023
@MBilalShafi MBilalShafi marked this pull request as ready for review October 23, 2023 19:47
cherniavskii
cherniavskii approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🎉

@MBilalShafi MBilalShafi merged commit f671a15 into mui:master Oct 24, 2023
18 checks passed
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Nov 6, 2023
@MBilalShafi @alexfauquette
[DataGridPremium] Fix cell selection throwing index error on second p…
b910dcb 
…age and beyond (mui#10784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Cell Selection Related to the cell selection feature
Projects
None yet
Milestone
No milestone
3 participants
@MBilalShafi @mui-bot @cherniavskii