Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Rename slots and slotProps types #10875

Merged
merged 10 commits into from
Nov 8, 2023

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Nov 2, 2023

From the PR comment

Offtopic nitpick: Have you considered going with PieArcPlotSlotProps and PieArcPlotSlots naming instead, because charts do not have the deprecated components part? 馃

#10782 (comment)

Changelog

Breaking changes

Types for slots and slotProps got renamed by removing the "Component" which is meaningless for charts.
Except if you imported those types, to create a wrapper, you should not be impacted by this breaking change.

Here is an example of the renaming for the <ChartsLegend /> component.

-ChartsTooltipSlotsComponent
+ChartsTooltipSlots

-ChartsTooltipSlotComponentProps
+ChartsTooltipSlotProps

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Nov 2, 2023
@mui-bot
Copy link

mui-bot commented Nov 2, 2023

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and way cleaner! 馃挴
WDYT about updating the changelog to list the ChartsTooltipSlots instead as that is the only actual breaking change of this PR. 馃

scripts/x-charts.exports.json Outdated Show resolved Hide resolved
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would need to add the migration guide 馃憤

@alexfauquette alexfauquette marked this pull request as ready for review November 8, 2023 10:58
@alexfauquette
Copy link
Member Author

Waiting for #10926 to be merged to add the explaination

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

github-actions bot commented Nov 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 8, 2023
@alexfauquette alexfauquette merged commit cb7dd8f into mui:next Nov 8, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: charts This is the name of the generic UI component, not the React module! typescript v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants