-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[charts] Rename slots
and slotProps
types
#10875
Conversation
Deploy preview: https://deploy-preview-10875--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and way cleaner! 馃挴
WDYT about updating the changelog
to list the ChartsTooltipSlots
instead as that is the only actual breaking change of this PR. 馃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would need to add the migration guide 馃憤
Waiting for #10926 to be merged to add the explaination |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
From the PR comment
#10782 (comment)
Changelog
Breaking changes
Types for
slots
andslotProps
got renamed by removing the "Component" which is meaningless for charts.Except if you imported those types, to create a wrapper, you should not be impacted by this breaking change.
Here is an example of the renaming for the
<ChartsLegend />
component.