Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add demo about how to use charts margin #10886

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

alexfauquette
Copy link
Member

New comment 馃憥
I find MUI X docs to be very confusing compared to Material-UI docs.

I'm trying to apply margin right now (as mentioned above). It won't take 'inherit' as a value, seems to only accept a number.

So I want to look at the definition of the margin prop: what are its default values?
Well I can't find the margin prop. It's not in the API reference under BarChart (which is what I'm using).
sent from https://mui.com/x/react-charts/styling/

https://mui-org.slack.com/archives/C04U3R2V9UK/p1698962389920629

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Nov 3, 2023
@mui-bot
Copy link

mui-bot commented Nov 3, 2023

Deploy preview: https://deploy-preview-10886--material-ui-x.netlify.app/

Updated pages:

Generated by 馃毇 dangerJS against 2b67f61

@LukasTy
Copy link
Member

LukasTy commented Nov 3, 2023

Am I missing something or is it actually different in how we place the chart in regards to x and y axes?
Having all the margins set to 0 hides the y axes, whereas x axes fit without problem.
Is there a reason for this difference that I'm not seeing? 馃
Screenshot 2023-11-03 at 14 12 27

@alexfauquette
Copy link
Member Author

@LukasTy It's not expected. For a reason I ignore the sizing is not working as expected. I added an issue for that

#10885

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 馃憤

@alexfauquette alexfauquette merged commit 6eeebad into mui:master Nov 3, 2023
20 checks passed
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants