[pickers] Make changeImportance and shortcut mandatory in PickersShortcuts

[flaviendelangle]

Closes #10940

[mui-bot]

Deploy preview: https://deploy-preview-10941--material-ui-x.netlify.app/

Updated pages:

• docs/data/migration/migration-pickers-v6/migration-pickers-v6.md

Generated by 🚫 dangerJS against 88f8c14

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[flaviendelangle]

@LukasTy @alexfauquette that one may have disappeared in your notifications
It's the last small breaking change remaining for the pickers

[alexfauquette]

I assume not providing the changeImportance will lead to broken shortcuts.
But for the item I'm not sure about what's the impact.

If I correctly understand, the usage of item is to provide some context to the onChange. What do you think about saying the last parameter is the shortcut context? Such that devs know they can pass whatever they think valuable for the onChange

[flaviendelangle]

If I correctly understand, the usage of item is to provide some context to the onChange

Yes, it's just passed directly to context.shortcut.

What do you think about saying the last parameter is the shortcut context? Such that devs know they can pass whatever they think valuable for the onChange

I guess it's unlikely that we will ever use this value for something else than just forwarding it to the context, so people should be able to pass whatever they want indeed.

Would you agree that it's not the role of the migration guide though? More the role of the shortcut doc if we want to highlight this ability at some point.

[alexfauquette]

Yes, it's just that it's the only place where this feature is explained for now

[LukasTy]

LGTM. 👌