Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add @next tag to the installation instructions #10963

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

@MBilalShafi MBilalShafi added docs Improvements or additions to the documentation v7.x labels Nov 9, 2023
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,19 +25,23 @@ To modify the styling of charts you can rely on all the MUI styling tools, such

## Getting started

:::warning
Note we're using the `next` tag to download the latest v7 **alpha** version.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the previous year's warning text, could we improve it a bit?
Reviewdog is also not happy about the use of we 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Suggested change
Note we're using the `next` tag to download the latest v7 **alpha** version.
The `next` tag is used to download the latest v7 **pre-release** version.

@@ -25,19 +25,23 @@ To modify the styling of charts you can rely on all the MUI styling tools, such

## Getting started

:::warning
Note we're using the `next` tag to download the latest v7 **alpha** version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it pre-release instead of alpha to avoid the need to update it after we start beta? 🤔
Or we should just have considered going with canary instead. 🙈

Suggested change
Note we're using the `next` tag to download the latest v7 **alpha** version.
Note we're using the `next` tag to download the latest v7 **pre-release** version.

@MBilalShafi MBilalShafi merged commit b5a027f into mui:next Nov 9, 2023
18 checks passed
@MBilalShafi MBilalShafi deleted the v7/next-tag branch November 9, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants