Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Arabic (ar-SD) locale #11096

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[l10n] Improve Arabic (ar-SD) locale #11096

merged 2 commits into from
Nov 21, 2023

Conversation

OmarWebDev
Copy link
Contributor

Hello, I have translated the "Manage Columns" in the arSD.ts file which was the only missing thing not translated.

Thanks.

@OmarWebDev
Translate "Manage Columns" to arabic
8d1713f 
Signed-off-by: Omar Khaled <52567999+OmarWebDev@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Nov 19, 2023 •
edited

Localization writing tips ✍️

Seems you are updating localization 🌍 files.

Thank you for contributing to the localization! 🎉 To make your PR perfect, here is a list of elements to check: ✔️

  • Verify if the PR title respects the release format. Here are two examples (depending if you update or add a locale file)

    [l10n] Improve Swedish (sv-SE) locale
    [l10n] Add Danish (da-DK) locale

  • Update the documentation of supported locales by running yarn l10n
  • Clean files with yarn prettier.

Deploy preview: https://deploy-preview-11096--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against a023ab9

@OmarWebDev OmarWebDev changed the title Translate "Manage Columns" to arabic [l10n] Improve Arabic (ar-SD) locale Nov 19, 2023
@flaviendelangle flaviendelangle changed the base branch from master to next November 20, 2023 08:46
@flaviendelangle flaviendelangle changed the base branch from next to master November 20, 2023 08:46
@flaviendelangle flaviendelangle added component: data grid This is the name of the generic UI component, not the React module! l10n localization labels Nov 20, 2023
@MBilalShafi MBilalShafi changed the base branch from master to next November 21, 2023 06:43
@MBilalShafi MBilalShafi changed the base branch from next to master November 21, 2023 06:43
MBilalShafi
MBilalShafi approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@MBilalShafi MBilalShafi merged commit f3365d6 into mui:master Nov 21, 2023
18 checks passed
MBilalShafi added a commit to MBilalShafi/mui-x that referenced this pull request Nov 21, 2023
@OmarWebDev @MBilalShafi
[l10n] Improve Arabic (ar-SD) locale (mui#11096)
2e95abd 
Signed-off-by: Omar Khaled <52567999+OmarWebDev@users.noreply.github.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
@MBilalShafi MBilalShafi mentioned this pull request Nov 21, 2023
Merged
@OmarWebDev OmarWebDev deleted the patch-1 branch November 22, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OmarWebDev @mui-bot @MBilalShafi @flaviendelangle